#contributions

Discussing the Implementation Change in Operations Class

TLDR Harpreet proposed a deviation in the Operations class. Kishore Nallan and Jason agreed to this change due to the improved clarity and compatibility.

Powered by Struct AI

1

8
31mo
Solved
Join the chat
Jul 06, 2021 (31 months ago)
Harpreet
Photo of md5-745d880d794220d9f0fb9ade17c6b861
Harpreet
08:22 AM
Kishore Nallan I'm thinking about deviating from the rest of the clients in the implementation of Operations class. Could you check this and provide your input?
https://github.com/happy-san/typesense-dart/commit/b30e9ed4fed608a1f1536315645015188268d8ff#diff-df4195f04d912ee6202323fb8bec8940c38b151f7ebb0569922bbd13f192c83fL9
Kishore Nallan
Photo of md5-4e872368b2b2668460205b409e95c2ea
Kishore Nallan
08:28 AM
I think this is better than having a perform -- not sure what we were thinking with that. Let's also run it by Jason before merging, but I think eventually even the clients are better off being more explicit here.
Harpreet
Photo of md5-745d880d794220d9f0fb9ade17c6b861
Harpreet
08:29 AM
sure
Jason
Photo of md5-8813087cccc512313602b6d9f9ece19f
Jason
02:50 PM
I wanted to not have to edit the clients for every type of operation we added to the server…
02:52
Jason
02:52 PM
I guess that also makes it hard to do types in static languages.
Kishore Nallan
Photo of md5-4e872368b2b2668460205b409e95c2ea
Kishore Nallan
02:52 PM
It makes discovery of the API difficult. Even in dynamic languages, IDEs can list available methods on the class.
Jason
Photo of md5-8813087cccc512313602b6d9f9ece19f
Jason
02:54 PM
Yeah, ok let’s switch to what you have Harpreet. I’ll update the other clients - it’s easy to do this in a backward compatible way.

1

Harpreet
Photo of md5-745d880d794220d9f0fb9ade17c6b861
Harpreet
03:27 PM
Sure

Typesense

Lightning-fast, open source search engine for everyone | Knowledge Base powered by Struct.AI

Indexed 3011 threads (79% resolved)

Join Our Community

Similar Threads

Discussing the Functionality and Structure of Typesense Client Libraries

Jason explained how Typesense client libraries function and their architecture. Jason and Masahiro guide Joe in his work on the Java client, emphasizing a consistent method call structure across different languages. Joe highlights his progress and difficulties.

3

7
33mo
Solved

Solving Typesense Cloud Interface Issue in Python

Orion had an issue querying from Python in the Typesense Cloud interface. Kishore Nallan identified the problem within the array declaration. They then discussed improving error messages and Orion offered to make a PR.

6

47
14mo
Solved

Typescript Support and Import Issues with Typesense

Ahmad faced trouble with Typesense support for Typescript. Jason assisted by suggesting checks and solutions. Phil suggested modifying the import statement. Ultimately, the issue was resolved with a change from Jason in version `v1.1.2`.

24
25mo

Resolving Duplicate Classes Error with Typesense and Kotlin

Matt faced "Duplicate class" errors in a Kotlin Android app after adding Typesense dependency. Kishore Nallan suggested excluding conflicting groups which resolved the issue.

2

13
10mo
Solved

Issue with Search Duration on Typesense Database

Robert reported an issue about query time delay when adding a `filter_by` constraint in a large Typesense database. Kishore Nallan explained that this happens due to the order of operation and also promised to look into this issue further. Robert withdrew his interest in sponsoring the improvement due to moving from the project.

13
10mo