<@U01PL2YSG8L> <@U076GF3T0HY> we’re continuing to ...
# community-help
m
@Kishore Nallan @Fanis Tharropoulos we’re continuing to test v30.1 curation sets, but the new “synonyms with curations” and “stemming with curations” features don’t seem to work for us. Following the docs, we set
rule.synonyms
and
rule.stem
to true, but the flags don’t persist when we retrieve the curation item. An example attached. Are we doing something wrong, or is this a known issue? Thanks.
ts-curation-synonyms-stem.txt
f
Hey @Max Priazhevskii, I'm taking a look. Will reply once I have news
🙌 1
Hey Max, You are not doing anything wrong. This is a bug in older builds around v30.1. Your PUT accepts rule.synonyms and rule.stem, but GET drops them. So it looks like they did not persist, and in some flows they actually stop working after that. It can work right after PUT, before any restart or reload or edit cycle. In that window, the rule is still in memory with those flags, so matching may apply stem and synonyms. It stops working after restart, snapshot restore, replication replay, or a GET then PUT update flow. Since GET omitted those fields, the next write saves the rule without them. After that, curation matching no longer uses stem or synonyms. This was fixed later in commit f194435a, PR #2769. Builds with this included are 30.2.rc1 and above
k
Don't think this is part of
30.2.rc1
yet because it's built from the v30 branch onto which I have not cherry-picked this fix yet.
m
Ok, thanks for confirming! Could you please let us know when a fix is available so we can test a new rc straight away?
@Kishore Nallan we’ve just tested rc3 and it looks like the fix isn’t in yet. Any idea when it might land? Thanks!
k
Will be merging today. Will post an update.
🎉 2
Please check on
30.2.rc4
m
Thanks @Kishore Nallan, can confirm the fix is working as expected in rc4. We’re testing the feature now. However, after upgrading from rc3 to rc4 we hit an issue - the relationships between collections and both curation sets and synonym sets were lost. All collections now have empty
curation_sets
and
synonym_sets
fields. Is this a known issue, and should we expect the same when upgrading prod from v29 to 30.2.rc4?
k
Is it possible for you to reproduce this issue trivially?
Note that you have to probably trigger a snapshot first because snapshot runs every hour and the issue might be related to restoring of relationships from disk after snapshot. Though nothing related to this changed in 30.2.rc4
m
Ok thanks. We’ve already restored relationships via APIs, but we’ll see if we can replicate the issue.
k
Just to confirm: the synonym sets and curations sets were there, but we just not linked to collections?
m
Yep, the sets were there, but no links in the collections
k
This did not happen during the initial v29 to v30 upgrade?
m
Correct. The initial upgrade was fine, with new sets and links in place
k
Ok, will check
🙌 1
We could not reproduce the issue. Check here: https://gist.github.com/kishorenc/a7f5656ece82a6d825d0e6a74061a4ab It will be great if you can share something like this which can showcase the issue.
m
Thanks for checking - we’ll try to replicate it on our end 👍
So far we’ve upgraded prod from
30.0.rc27
to
30.2.rc4
without any issues. We’ll keep an eye on the following RC updates.
👍 1