Just wanted to thank you guys. Recently setup Typsense on Digitalocean instance, w Laravel scout, and its performing wonderfully. Was able to index 350k documents within an hour or so. I originally tried meilsearch due to the first party laravel support, but it was taking over a day to index the records. I think getting your scout engine featured on Laravel Scout docs, would be a huge benefit.

That's great to hear @Joe! If you're able to increase the number records per batch, you might be able to index even faster! For eg, I've been able to index the recipe dataset that powers the home page demo with 2.2M records in about 3-4 minutes by sending it all in one giant batch

Yep. I probably could have done that, but its no big deal, since I was using scout + queue, so the import was async.

I think getting your scout engine featured on Laravel Scout docs, would be a huge benefit.

That would be awesome, and something I'd love to make happen. We're essentially looking for some one (or multiple folks) from the community to help with the native scout integration, which I believe is a requirement to get featured in the Laravel docs. We have the standalone scout adapter already, thanks to @Abdullah Al-Faqeir and @hi019! Would be great if we can now integrate that natively into Laravel

I actually submitted bug report for that - https://github.com/typesense/laravel-scout-typesense-driver/issues/13

re: bug report - yeah, had to deal with this in the JS library as well... where we later raised an exception when we detect import errors, instead of asking users to parse the response: https://github.com/typesense/typesense-js/blob/95bf000f0191b4d3c48854a238bbf55ed5e0483b/src/Typesense/Documents.ts#L203-L213 Need to do this in the PHP library as well

Would be great if we can now integrate that natively into Laravel

Agreed. Note that Typesense would need to commit to maintaining the integration, even though it is in the laravel/scout repo. See this comment. As I mentioned to Jason a few months ago, I won’t be able to provide continuous support for the repo (while Typesense is great, I have other projects + school, and I don’t use php anymore) Regarding @Joe’s issue, I saw a commit in the devloops repo that should fix this. Abdullah wrote a few other commits as well since we forked their repo, so I’ll just do a rebase + patch sometime soon

Note that Typesense would need to commit to maintaining the integration, even though it is in the laravel/scout repo. See this comment.

Yeah, that's the part that I need help with... I used PHP several years ago and I'm not familiar with Laravel to feel comfortable maintaining a deep framework integration by myself

I won’t be able to provide continuous support for the repo (while Typesense is great, I have other projects + school, and I don’t use php anymore)

Got it. @Abdullah Al-Faqeir how about you? If you're down to contributing your work into Laravel core, I'm happy to at least start the conversation on the Laravel repo, similar to what hi09 linked above, and then let you take it from there.

Regarding Joe’s issue, I saw a commit in the devloops repo that should fix this. Abdullah wrote a few other commits as well since we forked their repo, so I’ll just do a rebase + patch sometime soon

🙏

@Jason Bosco I’m definitely down with you guys!!

@Abdullah Al-Faqeir That's awesome! Thank you. I'll open an issue next week in the Laravel repo and also tag you in it as offering to maintain it in Laravel core. It would be great if you can then add a comment in the issue, reaffirming that you're down to maintain it. I'm excited about this!

Sure!!! I’m way more excited 😆

Nice, glad we'll be able to get Typesense integrated into Laravel. In that case, I don't think it's necessary for me to update the TS repo with @Abdullah Al-Faqeir's changes because users can just wait until Abdullah's PR is merged. But I'll add a hotfix for the import bug in the meantime

@hi019 You had made additional changes in the repo we forked into the Typesense org (changing namespaces etc), so I’d imagine we want to use that as the basis for the work we’d contribute into the Laravel code base…

All of the improvements I made (config changes, deduplicating some code, renaming the driver to typesense) have since been added to Abdullah's repo. Except for renaming the TypesenseSearch interface to TypesenseDocment, that is. Also, we'll need to change the namespace with the Scout PR either way, since the code will be moved to Laravel\Scout. Though, I'll still merge the changes because it will probably look better to the Laravel team if the PR is based on a repo under the Typesense organization. And it won't take too much time because it's just changing some paths :)

Yup will do!

Cool!

To be sure, shall I mention your name in addition to Abdullah’s as proposed maintainers for the contribution into Laravel core, or did you just want me to CC you?

Just a CC is fine

@Abdullah Al-Faqeir I've created the request here: https://github.com/laravel/scout/issues/543 Would be great if you can add a comment to the issue re-affirming that you're down to be a maintainer for this integration. Also, CC: @hi019

It’s unfortunate, but I understand the reasoning. I’ll merge Abdullah’s changes sometime this weekend/next week and maybe you can give him commit access too?

Abdullah should already have commit access to the repo