#contributions

Typesense Java Contribution and Swagger Codegen Issue

TLDR Nathan had issues with the swagger codegen while contributing to a Typesense project. Kishore Nallan merged their api spec changes, and Nathan resolved the issue by adjusting their file copying method.

Powered by Struct AI
5
4mo
Solved
Join the chat
Jun 07, 2023 (4 months ago)
Nathan
Photo of md5-aa846ac80f1164f0d27b340467fd28e2
Nathan
08:11 PM
I am trying to make a contribution for https://github.com/typesense/typesense-java/issues/41. When I followed the swagger codegen instructions, it updated almost every single file as shown in the screenshot below. Is this expected?
Image 1 for I am trying to make a contribution for <https://github.com/typesense/typesense-java/issues/41>. When I followed the swagger codegen instructions, it updated almost every single file as shown in the screenshot below. Is this expected?
Jason
Photo of md5-8813087cccc512313602b6d9f9ece19f
Jason
08:11 PM
CC: Kishore Nallan ^
Nathan
Photo of md5-aa846ac80f1164f0d27b340467fd28e2
Nathan
08:39 PM
Here's my first PR for changing the api spec: https://github.com/typesense/typesense-api-spec/pull/37
Jun 08, 2023 (4 months ago)
Kishore Nallan
Photo of md5-4e872368b2b2668460205b409e95c2ea
Kishore Nallan
02:52 AM
๐Ÿ‘‹ I've merged the change to the spec. thanks!

&gt; When I followed the swagger codegen instructions, it updated almost every single file as shown in the screenshot below. Is this expected?
I wonder if this because of a different version of the client generator being used or maybe the params used. I will document this and update this thread so you can try again.
Nathan
Photo of md5-aa846ac80f1164f0d27b340467fd28e2
Nathan
05:32 PM
I figured out what happened here. It's just the way I copied the files over -- I did it within my IDE so it applied auto-formatting. It had nothing to do with the swagger generation jar.